Skip to content

hide alloc::alloc::box_new in docs #147847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2025
Merged

hide alloc::alloc::box_new in docs #147847

merged 1 commit into from
Oct 19, 2025

Conversation

@WaffleLapkin
Copy link
Member

It's an internal function which isn't supposed to be used outside standard library / vec!.

@WaffleLapkin
hide alloc::alloc::box_new in docs
d17dbc7 
It's an internal function which isn't supposed to be used outside
standard library / `vec!`.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Oct 18, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit d17dbc7 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@bors
Copy link
Collaborator

bors commented Oct 19, 2025

⌛ Testing commit d17dbc7 with merge 33cab8c...

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

☀️ Test successful - checks-actions
Approved by: joboet
Pushing 33cab8c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2025
@bors bors merged commit 33cab8c into rust-lang:master Oct 19, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e124355 (parent) -> 33cab8c (this PR)

Test differences

Show 207 test diffs

207 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 33cab8c4c702d08f1d55997c5df70d7df8aa3b8b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7219.4s -> 8310.3s (15.1%)
  2. dist-various-1: 3715.1s -> 4201.2s (13.1%)
  3. dist-x86_64-apple: 7236.2s -> 7830.4s (8.2%)
  4. arm-android: 5869.0s -> 5389.0s (-8.2%)
  5. i686-msvc-2: 8055.2s -> 7409.0s (-8.0%)
  6. x86_64-msvc-ext3: 6111.1s -> 6587.4s (7.8%)
  7. i686-gnu-nopt-1: 7676.1s -> 7171.2s (-6.6%)
  8. dist-apple-various: 3607.1s -> 3372.4s (-6.5%)
  9. x86_64-gnu-aux: 6856.5s -> 6443.0s (-6.0%)
  10. aarch64-gnu-debug: 3856.5s -> 3624.0s (-6.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (33cab8c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.911s -> 473.834s (0.20%)
Artifact size: 390.54 MiB -> 390.55 MiB (0.00%)

@bors bors mentioned this pull request Oct 19, 2025
Draft
@WaffleLapkin WaffleLapkin deleted the hide_box_new branch October 19, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@WaffleLapkin @rustbot @joboet @bors @rust-timer